flo-l commented on pull request #1525: URL: https://github.com/apache/systemds/pull/1525#issuecomment-1038879827
Thank you for your comments :) I'm with @sebwrede. It really depends how we're defining the purpose of NativeHelper. The name suggests it's a general binding mechanism to all native code. I want to make a strong case in favor of building only one native lib and then linking all java code through only one class (NativeHelper) with it. The problem with these JNI bindings is complexity. The system is already quite complex and it was hard for me as a new contributor to the project to find my way around. Keeping linkage and native Java methods in one place each really is the simplest solution. Once we start linking several dylibs complexity only grows, with no big gain in code clarity imho. I would even go so far and say that a multi-lib solution would be way harder to understand, debug and get running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
