kev-inn opened a new pull request, #1628: URL: https://github.com/apache/systemds/pull/1628
This reworks our runtime replacement of CP instructions with FED versions when appropriate. SP replacement will be done in another PR. This implementation was my second approach, the first one consisted of static methods in the FED instructions. I much prefer this one as it is quite clear which instructions are replaced, which constraints the CP imposes and we don't have to lead every check with an `instanceof` check. The downside of this approach is that it can get a bit confusing with inheritance, but it is---and will probably stay---manageable. Note that not everything is replaced yet, I will work on it while the general approach can already be reviewed. During the testing I found myself requiring to check if actual FED instructions are executed, is there a way to ensure this in the test framework, or is this already ensured in some way via privacy? Tests checking the heavy hitters do it implicitly. NOTE: I deleted a fix in `QuantilePickCPInstruction` (bf19244c909ae8354bc8b3da0985eaf448aa5f0c), as the common layout is no longer necessary and null is cleaner. This is intentional and the fix is no longer necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
