kev-inn commented on PR #1628: URL: https://github.com/apache/systemds/pull/1628#issuecomment-1149805822
Sure, that is the number one priority of this rework, that is why I also would like to remove the dependency for the string representations of those instructions to be similar/matching. In the future we want to send only CP instructions to the workers and locally choose CP, SP or GPU (maybe even FED?). Keeping this in mind, we could add conversions for all kinds of instructions to CP (and require constructors like the ones I added for FED) or add interfaces with getters for specialized instructions like `BinaryAggregationInstruction`. The approach, which should be the nicest to work with, would be a complete rework of the hierarchy of instructions, adding the type of execution only at the leaf specializations. Instead of `ComputationCPInstruction` and `ComputationSPInstruction` we would have `ComputationInstruction. This would require a very intrusive change of a lot of core implementations and seems infeasable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
