j143 commented on PR #1641: URL: https://github.com/apache/systemds/pull/1641#issuecomment-1164557978
I have only verified the angular UI, (I will test the full functionality while running the federated experiments shortly.) 1. we can customize README and add license! 2. we can remove package-lock.json. Although, the standard practice is to include in a web repo, here we can keep the code concise by removing the generated code as much as possible. 3. You can add documentation (like a small diagram of the data model if possible), so that people can easily extend it. 4. Of course, as Sebastian mentioned let's add test for each component. 5. Also, let only reveal the enough info in the logs - if need be we can extend it later. Best, Janardhan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
