MKehayov commented on PR #1641: URL: https://github.com/apache/systemds/pull/1641#issuecomment-1166312524
Hey, @j143 thank you for the points, my fixes on them are the following: 1. I have added README files for the angular UI and backend, a license is included in the angular one. 2. I agree, that it is a standard practice to have the package-lock in the repo, it is currently there, but let me know if I should remove it. 3. Added in the README file of the backend and the API reference can be found in the angular README. 4. I added at least one test for every component, they currently sum up to 36. 5. I removed the logging of the errors in the StatsService, let me know where else you think we should remove the logs. Best, Mito -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
