louislepage commented on code in PR #1849:
URL: https://github.com/apache/systemds/pull/1849#discussion_r1243206329
##########
src/main/java/org/apache/sysds/common/Types.java:
##########
@@ -76,7 +76,7 @@ public boolean isUnknown() {
*/
public enum ValueType {
UINT4, UINT8, // Used for parsing in UINT values from numpy.
- FP32, FP64, INT32, INT64, BOOLEAN, STRING, UNKNOWN,
+ FP32, FP64, INT32, INT64, BOOLEAN, TRUE_BOOLEAN, STRING,
UNKNOWN,
Review Comment:
I can reuse the old BOOLEAN type, yes. The reason for having two boolean
types right now is to compare the bitset boolean denseblocks and the "true"
boolean array denseblocks.
I would suggest renaming the "old" BOOLEAN, which currently is the bitset
implementation, to BITSET and using BOOLEAN for the boolean array. That naming
would make things more clear.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
