louislepage commented on code in PR #1849:
URL: https://github.com/apache/systemds/pull/1849#discussion_r1251842844
##########
src/main/java/org/apache/sysds/common/Types.java:
##########
@@ -76,7 +76,7 @@ public boolean isUnknown() {
*/
public enum ValueType {
UINT4, UINT8, // Used for parsing in UINT values from numpy.
- FP32, FP64, INT32, INT64, BOOLEAN, STRING, UNKNOWN,
+ FP32, FP64, INT32, INT64, BOOLEAN, TRUE_BOOLEAN, STRING,
UNKNOWN,
Review Comment:
I have to revert this renaming. This Valuetype is used for so much more than
just denseblocks, which I did not get the first time...
I will reuse the existing Valuetype.BOOLEAN and use another mechanism to
create BooleanArrays when desired.
In the end, it makes a lot more sense when both DenseBlockBool
implementations use the same ValueType, since both store booleans in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
