fzoepffel commented on code in PR #1983:
URL: https://github.com/apache/systemds/pull/1983#discussion_r1461655069
##########
src/main/java/org/apache/sysds/runtime/instructions/cp/MultiReturnBuiltinCPInstruction.java:
##########
@@ -90,6 +90,23 @@ else if ( opcode.equalsIgnoreCase("eigen") ) {
return new MultiReturnBuiltinCPInstruction(null, in1,
outputs, opcode, str);
}
+ else if ( opcode.equalsIgnoreCase("fft") ) {
+ // one input and two outputs
+ CPOperand in1 = new CPOperand(parts[1]);
+ outputs.add ( new CPOperand(parts[2], ValueType.FP64,
DataType.MATRIX) );
+ outputs.add ( new CPOperand(parts[3], ValueType.FP64,
DataType.MATRIX) );
+
+ return new MultiReturnBuiltinCPInstruction(null, in1,
outputs, opcode, str);
+
+ }
+ else if ( opcode.equalsIgnoreCase("ifft") ) {
+ // one input and two outputs
+ CPOperand in1 = new CPOperand(parts[1]);
+ outputs.add ( new CPOperand(parts[2], ValueType.FP64,
DataType.MATRIX) );
+ outputs.add ( new CPOperand(parts[3], ValueType.FP64,
DataType.MATRIX) );
+
+ return new MultiReturnBuiltinCPInstruction(null, in1,
outputs, opcode, str);
Review Comment:
ifft is not handled here anymore. Instead a new
MultiReturnComplexMatrixBuiltinCPInstruction was added to allow for 1 or 2
inputs for ifft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
