fzoepffel commented on PR #1983: URL: https://github.com/apache/systemds/pull/1983#issuecomment-1935589905
> > > > The remaining conflicts were just resolved. Now the PR should be ready to merge. Further validation(e.g. empty inputs, differing dimensions of imaginary and real inputs, etc.) and minor bug fixes like the handling of only zero input matrices will come in a separate PR for the integrated python tests. Currently the workflows are waiting for this PR are awaiting approval. Hopefully the integrationtests that were failing before will succeed now. We are assuming that these integration tests are not related to us. Please let us know if you think differently. > > > > > > > > > Hi @fzoepffel > > > The code passes all tests, great. > > > I think your codeformatter ran in many of the PR files. Can we revert this? We try to avoid formatting existing files (even if the format is wrong) unless we do major changes. > > > > > > I just saw. I am a little unsure however, how I can revert this. When I run the formatter (which I configured to use the CodeStyle_eclipse.xml file) it does not necessarily reverse to what it was before. > > The files was just not formatted before. Not everyone formats the files, and we have some legacy/old code that we would rather have refer to the original authors rather than change the format of it. Therefore i have configured my IDE only for format on request not automatically. > > A concrete way of handling it is a bit more tricky. I suggest going back through commits and figuring out which commit did the formatting, and then revert the formatting without breaking the changes that you wanted to do. There probably is a smarter way, but I am unaware of such. The legacy had mainly been formatted in three commits. I reversed the hunks of these commits that were not related to our fft implementation. Since I had to do this for each file individually I added a "reverse formatting" commit for each file. Unfortunately two tests are failing now (see [**.functions.federated.monitoring.**,**.functions.federated.multitenant.**](https://github.com/apache/systemds/actions/runs/7837353259/job/21398216259?pr=1983#logs) [**.component.c**.**](https://github.com/apache/systemds/actions/runs/7837353259/job/21398211615?pr=1983#logs)). I think that these tests have nothing to with our code though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
