fzoepffel opened a new pull request, #1995: URL: https://github.com/apache/systemds/pull/1995
## Overview Python tests for the FFT and IFFT implementations were added. Also validation checks were added that should hopefully filter out all edge cases. Handling of zero matrix inputs and empty matrices was also implemented. This PR has been rebased on the main PR that implements FFT and IFFT and integrates it into DML. Thus it has to be merged after this PR. See https://github.com/apache/systemds/pull/1983. ## Testing Run the tests in systemds/src/main/python/tests/matrix/test_fft.py and see if they are all going through. The tests can be run by doing the following: ### Go to the root of the project. Then run: ``` python3.8 -m venv venv source venv/bin/activate ``` ### make sure to set the following env variables in your venv: ``` export SYSTEMDS_ROOT=$(pwd) export PATH=$SYSTEMDS_ROOT/bin:$PATH export SYSDS_QUIET=1 ``` ### Then run: ``` pip install --upgrade pip pip install wheel numpy py4j scipy scikit-learn requests pandas unittest-parallel mvn clean package -P distribution cd src/main/python/ python create_python_dist.py python -m unittest discover -s tests -p 'test_fft.py' ``` ### For deactivating the venv run: `deactivate` After validating the tests review the code for the validation and check if any edge cases might be missing in systemds/src/main/java/org/apache/sysds/parser/BuiltinFunctionExpression.java and also check the handling of non-zero matrices in systemds/src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java. Contributors: @fzoepffel @jessicapriebe @mufwan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
