Baunsgaard commented on code in PR #1995:
URL: https://github.com/apache/systemds/pull/1995#discussion_r1483241644
##########
src/main/python/tests/matrix/test_fft.py:
##########
Review Comment:
good tests
##########
src/main/java/org/apache/sysds/runtime/privacy/propagation/PrivacyPropagator.java:
##########
Review Comment:
This file should not be modified
##########
src/main/python/systemds/operator/nodes/matrix.py:
##########
@@ -343,6 +345,32 @@ def cholesky(self, safe: bool = False) -> 'Matrix':
"""
return Matrix(self.sds_context, 'cholesky', [self])
+ def fft(self):
+ """
+ Performs the Fast Fourier Transform (FFT) on this matrix.
+ Returns a Matrix object representing the FFT (complex numbers
represented as two matrices).
Review Comment:
the syntax for documentation is not followed, take a look at some of the
other examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
