jessicapriebe commented on code in PR #1983:
URL: https://github.com/apache/systemds/pull/1983#discussion_r1495039456
##########
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixFourier.java:
##########
@@ -440,4 +444,18 @@ public static MatrixBlock[] ifft_linearized(MatrixBlock
re, int threads) {
threads);
}
+ private static double sin(double angle){
+ if (!sinCache.containsKey(angle)) {
Review Comment:
Would it also be fine to materialize the cache inside of fft() or
fft_one_dim()? As far as I can see, cos or sin is never computed for the same
values in fft_one_dim_sub() and therefore there would be no benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
