fzoepffel commented on PR #2116:
URL: https://github.com/apache/systemds/pull/2116#issuecomment-2373769232

   > could you please rebase this PR and resolve the merge conflicts yourself 
@fzoepffel - the PR actually starts from the wrong code base and overwrites the 
new disableIncApproxPruning flag (introduced 10 days ago) which makes all the 
tests fail.
   
   Thank you for the reminder; it slipped my mind. I just rebased the PR, and 
to save some lines of code, I adjusted the disabling a bit to **enable** rather 
than **disable** the strategies, as all strategies are only enabled in two 
cases (1. all enabled, 2. only the respective strategy enabled), while they'd 
have to be disabled in more cases. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to