fzoepffel commented on PR #2116: URL: https://github.com/apache/systemds/pull/2116#issuecomment-2374656840
I just added another bigger change to this PR. As you, @mboehm7, commented in my thesis, the current state management is not working correctly for incremental updates that are based on stats and lattice from a run of incSliceLine that already depends on stats and lattice from an even earlier run. This is because the slices and stats that are pruned through incremental pruning methods are not stored for subsequent increments even though we mostly have all the necessary information. I updated the code to track the lost slices and stats and add them to the output lattice and statistics (L and Stats) lists as well. Also, currently, some tests run into errors when enabling the new approx pruning method, which is why for now I set the enabling boolean to FALSE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
