min-guk opened a new pull request, #2273: URL: https://github.com/apache/systemds/pull/2273
This PR introduces a draft of the `getFederatedType` function in `FederatedPlanRewireTransTable.java`, which determines and propagates `FType` in the cost-based federated planner. The function integrates and extends `allowFederated` and `getFederatedOut` from `AFederatedPlanner`, aiming to support more operations. Referenced: - `sysds/hops/*Op.java` - `sysds/runtime/instructions/fed/*FEDInstruction.java` - `sysds/hops/fedplanner/AFederatedPlanner.java` - `sysds/hops/fedplanner/FederatedPlannerFedAll.java` Currently, most `FType` values returned by `getFederatedType` are still `null`, so the implementation is likely insufficient and incomplete. Please review whether the logic correctly handles opcodes and input types. **Note:** - This PR should ideally be split, but wasn't due to time constraints. - Many tests are currently failing. - I plan to cancel this PR and re-submit smaller ones after review. Thanks in advance for your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
