min-guk commented on code in PR #2273:
URL: https://github.com/apache/systemds/pull/2273#discussion_r2148104729
##########
src/main/java/org/apache/sysds/hops/fedplanner/FederatedMemoTable.java:
##########
@@ -28,16 +28,21 @@
import org.apache.commons.lang3.tuple.Pair;
import org.apache.commons.lang3.tuple.ImmutablePair;
import
org.apache.sysds.runtime.instructions.fed.FEDInstruction.FederatedOutput;
+import org.apache.sysds.common.Types.ExecType;
/**
- * A Memoization Table for managing federated plans (FedPlan) based on
combinations of Hops and fedOutTypes.
- * This table stores and manages different execution plan variants for each
Hop and fedOutType combination,
+ * A Memoization Table for managing federated plans (FedPlan) based on
+ * combinations of Hops and fedOutTypes.
+ * This table stores and manages different execution plan variants for each Hop
+ * and fedOutType combination,
* facilitating the optimization of federated execution plans.
*/
public class FederatedMemoTable {
// Maps Hop ID and fedOutType pairs to their plan variants
private final Map<Pair<Long, FederatedOutput>, FedPlanVariants>
hopMemoTable = new HashMap<>();
+ public void addFedPlanVariants(long hopID, FederatedOutput fedOutType,
FedPlanVariants fedPlanVariants) {
+ hopMemoTable.put(new ImmutablePair<>(hopID, fedOutType),
fedPlanVariants);
Review Comment:
Thanks for checking!
I'm on my way home now, so I'll take another look and upload it once I get
back.
Appreciate you letting me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
