j143 commented on code in PR #2317:
URL: https://github.com/apache/systemds/pull/2317#discussion_r2308250068
##########
src/main/java/org/apache/sysds/hops/rewrite/RewriteInjectOOCTee.java:
##########
@@ -212,7 +228,7 @@ private void applyTopDownTeeRewrite(Hop sharedInput) {
private boolean isNotAlreadyTee(Hop hop) {
if (hop.getParent().size() > 1) {
for (Hop consumer : hop.getParent()) {
- if (consumer instanceof TeeOp) {
+ if (consumer instanceof DataOp) {
Review Comment:
this check only checking for DataOp.
##########
src/main/java/org/apache/sysds/hops/rewrite/RewriteInjectOOCTee.java:
##########
@@ -175,7 +178,20 @@ private void applyTopDownTeeRewrite(Hop sharedInput) {
ArrayList<Hop> consumers = new
ArrayList<>(sharedInput.getParent());
// Create the new TeeOp with the original hop as input
- TeeOp teeOp = new TeeOp(sharedInput);
+// TeeOp teeOp = new TeeOp(sharedInput);
+ DataOp teeOp = new DataOp("tee_out_" + sharedInput.getName(),
+ sharedInput.getDataType(),
+ sharedInput.getValueType(),
+ Types.OpOpData.TRANSIENTWRITE,
Review Comment:
Is it supposed to be TRANSIENTWRITE or TRANSIENTREAD?
##########
src/main/java/org/apache/sysds/hops/rewrite/RewriteInjectOOCTee.java:
##########
@@ -175,7 +178,20 @@ private void applyTopDownTeeRewrite(Hop sharedInput) {
ArrayList<Hop> consumers = new
ArrayList<>(sharedInput.getParent());
// Create the new TeeOp with the original hop as input
- TeeOp teeOp = new TeeOp(sharedInput);
+// TeeOp teeOp = new TeeOp(sharedInput);
+ DataOp teeOp = new DataOp("tee_out_" + sharedInput.getName(),
Review Comment:
presently we are creating different variable names than the ones created
automatically _mvar1 ... --> is this the correct approach.
##########
src/main/java/org/apache/sysds/hops/DataOp.java:
##########
@@ -32,12 +32,8 @@
import org.apache.sysds.conf.CompilerConfig.ConfigType;
import org.apache.sysds.conf.ConfigurationManager;
import org.apache.sysds.hops.rewrite.HopRewriteUtils;
-import org.apache.sysds.lops.Data;
-import org.apache.sysds.lops.Federated;
-import org.apache.sysds.lops.Lop;
+import org.apache.sysds.lops.*;
import org.apache.sysds.common.Types.ExecType;
-import org.apache.sysds.lops.LopsException;
-import org.apache.sysds.lops.Sql;
Review Comment:
I'll remove *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
