j143 commented on code in PR #2317: URL: https://github.com/apache/systemds/pull/2317#discussion_r2310084158
########## src/main/java/org/apache/sysds/lops/Tee.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.sysds.lops; + +import org.apache.sysds.common.Types; +import org.apache.sysds.common.Types.DataType; +import org.apache.sysds.common.Types.ValueType; +import org.apache.sysds.runtime.instructions.InstructionUtils; + +public class Tee extends Lop { + + public static final String OPCODE = "tee"; + /** + * Constructor to be invoked by base class. + * + * @param input1 lop type + * @param dt data type of the output + * @param vt value type of the output + */ + public Tee(Lop input1, DataType dt, ValueType vt) { + super(Lop.Type.Tee, dt, vt); + this.addInput(input1); + input1.addOutput(this); + lps.setProperties(inputs, Types.ExecType.OOC); + } + + @Override + public String toString() { + return "Operation = Tee"; + } + + @Override + public String getInstructions(String input1, String outputs) { + + String[] out = outputs.split(Lop.OPERAND_DELIMITOR); + String output2 = outputs + "_copy"; + + // This method generates the instruction string: OOC°tee°input°output1°output2... Review Comment: thanks @mboehm7 . Are you referring to the way, where we have lightweight marker for the stream so the multiple consumers could utilize it. Please let me raise a different PR with the option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
