MegaByteTron opened a new pull request, #2497:
URL: https://github.com/apache/systemds/pull/2497
## Summary
The federated `QuantilePickFEDInstruction` only enabled the even-length
averaging branch for `MEDIAN`, while the CP reference path
(`QuantilePickCPInstruction`) applies the same averaging convention for
`VALUEPICK` by passing `matBlock.getLength() % 2 == 0` to
`MatrixBlock.pickValue`.
As a result, `quantile(A, p)` on a federated matrix with an even row
count diverged from the CP reference (which `compareResults(1e-9)`
rejects), causing the `federatedQuantile{1,2,3}{CP,SP}` tests to fail.
They were previously marked `@Ignore` to hide the failure.
## Change
- Extend the `average` flag in `processRowQPick` to also cover
`VALUEPICK` so the federated path mirrors the CP averaging contract.
The existing guard
```
average = average && (... rows ...) % 2 == 0
```
keeps averaging disabled for odd-length input, matching CP. `IQM` is
intentionally excluded because it has its own interpolation path.
- Un-ignore the six previously-disabled tests
(`federatedQuantile{1,2,3}{CP,SP}`) and drop the unused
`org.junit.Ignore` import.
## Test plan
- [x] `FederatedQuantileTest` — all 12 tests pass locally (CP + SP),
including the six previously-ignored ones.
- [x] `federatedMedian{CP,SP}`, `federatedIQR{CP,SP}`,
`federatedQuantiles{CP,SP}` still pass — `IQM` and `MEDIAN`
paths untouched.
Resolves https://issues.apache.org/jira/browse/SYSTEMDS-3922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
