MegaByteTron commented on PR #2497: URL: https://github.com/apache/systemds/pull/2497#issuecomment-4952818995
Hi @ywcb00, thanks for the pointer! I've added a second commit ([`4ace52d`](https://github.com/apache/systemds/pull/2497/commits/4ace52d0d2)) tagged `[SYSTEMDS-3898]` that mirrors the CP fix pattern for the unweighted SP path in `QuantilePickSPInstruction.getWeightedQuantileSummary` — the length-based `mc.getRows() % 2 == 0` condition from `3ae6a77`, plus the boundary guard analog of `ebdabf1`. `testQuantileBugSP` is un-ignored and green locally alongside the rest of `QuantileTest`. The weighted branch (`mc.getCols() == 2`) is intentionally left as-is to match the scope note from `3ae6a77` about weighted kernels needing a more involved implementation — the existing TODO stays in place there. Let me know if you'd like anything adjusted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
