ywcb00 commented on code in PR #2596:
URL: https://github.com/apache/systemds/pull/2596#discussion_r3863276000
##########
src/main/java/org/apache/sysds/hops/recompile/Recompiler.java:
##########
@@ -387,6 +388,11 @@ else if( !codegen ) {
memo.extract(hops, status);
}
+ // sparsity-based DAG recompilation if enabled
+
if(ConfigurationManager.getDMLConfig().getBooleanValue(DMLConfig.SPARSITY_RECOMPILE))
{
+ hops = SparsityDAGRecompiler.optimize(hops, ec);
+ }
+
Review Comment:
As it is right now, yes absolutely. The current version replicates the
`RewriteMatrixMultChainOptimizationSparse`, which is still a part of the
statistics optimizations.
In the future, the sparsity-based recompiler will perform modifications that
are comparable to the code generation. Considering the planned future progress,
I believe this will be the correct location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
