ywcb00 commented on code in PR #2596:
URL: https://github.com/apache/systemds/pull/2596#discussion_r3879037948
##########
src/main/java/org/apache/sysds/hops/recompile/Recompiler.java:
##########
@@ -387,6 +388,11 @@ else if( !codegen ) {
memo.extract(hops, status);
}
+ // sparsity-based DAG recompilation if enabled
+
if(ConfigurationManager.getDMLConfig().getBooleanValue(DMLConfig.SPARSITY_RECOMPILE))
{
+ hops = SparsityDAGRecompiler.optimize(hops, ec);
+ }
+
Review Comment:
I stand corrected. I misunderstood something about the current Recompiler.
You are absolutely right! Consequently, I am thinking about not merging this
PR, since this separation is not needed. Thank you for pointing this out. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
