jessicapriebe commented on code in PR #2619:
URL: https://github.com/apache/systemds/pull/2619#discussion_r4073044345
##########
src/main/java/org/apache/sysds/runtime/ooc/cache/packed/OOCPackedCache.java:
##########
@@ -47,7 +47,7 @@
public final class OOCPackedCache implements OOCCache {
private static final long PACKED_STREAM_ID =
CachingStream._streamSeq.getNextID();
- private static final long DEFAULT_PACK_THRESHOLD_BYTES = 1L << 18;
+ private static final long DEFAULT_PACK_THRESHOLD_BYTES = 1;
Review Comment:
Thanks for your feedback! I’ve already addressed some of it. Jannik and I
discussed this one, and he’ll rebuild the OOCPackedCache. We decided to disable
it for now by setting the threshold to 1. I’ve just added a comment to make
this clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
