Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410380592
##########
File path: src/main/python/tests/test_matrix_aggregations.py
##########
@@ -84,6 +86,63 @@ def test_var2(self):
def test_var3(self):
self.assertTrue(np.allclose(sds.matrix(m1).var(axis=1).compute(),
m1.var(axis=1, ddof=1).reshape(dim, 1)))
+ def test_rand_basic(self):
+ seed = 15
+ shape = (20, 20)
+ min_max = (0, 1)
+ sparsity = 0.2
Review comment:
Try setting up the tests such that it runs with multiple parameters, without
code duplication (preferably such that each parameter set counts as a distinct
test case).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
