Baunsgaard commented on a change in pull request #892: Extend Python API (rand,
lm, matrix multiplication)
URL: https://github.com/apache/systemml/pull/892#discussion_r410384979
##########
File path: src/main/python/systemds/matrix/operation_node.py
##########
@@ -229,3 +233,10 @@ def moment(self, moment, weights: DAGNode = None) ->
'OperationNode':
unnamed_inputs.append(weights)
unnamed_inputs.append(moment)
return OperationNode(self.sds_context, 'moment', unnamed_inputs,
output_type=OutputType.DOUBLE)
+
+ def lm(self, y: DAGNode, **kwargs) -> 'OperationNode':
Review comment:
(Suggestion) Could it make sense to move this lm function to a new file?
I can imagine that if we add all functions to this file it will become
harder to look over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
