Dear Camellia, I'm sorry for the belated reply. In overall, I agree on your approach. Your work looks great. However, I would like to advise a couple of things.
First, although the part on which you have focused is not frequently updated, I would like to encourage you to rebase continually your work on updated source code. Your current work is based on the old revision of Tajo. Sometimes, a number of small changes may make code merge very hard. Second, I think that LogicalOptimizer class is the better place to perform validateOuterJoin and rewriteOuterJoin methods. Those methods seem to be executed before selection and projection push down. You could place your methods before them. Finally, maybe, you've tried to traverse join conditions (i.e., EvalTree). EvalTreeUtil has various and helpful methods that you may want. In addition, I'm always available on google talk (hyunsik dot choi at gmail dot com). If you don't have google account, I'll be on #tajo at freenode. If you want to discuss something in an instance way, please use either one. Best regards, Hyunsik Choi On Fri, Jul 5, 2013 at 6:50 AM, camelia c <[email protected]> wrote: > Hello, > > Thank You for Your kind feedback! > > I began coding and I uploaded the source code written so far on the > website at https://sites.google.com/site/gsoc2013tajo34/home/validation. > > It is uploaded as an attachment and there are some other files with tests > I've done. > > I continue with the optimization of changing outer joins to inner joins, > whenever suitable , in method rewriteOuterJoin, as proposed in EXT 3.3 in > the Software Design Document. > > In the following days I shall upload this source code as well. > > Please be kind to give me feedback of whether You are content with the > source code I wrote so far and if You agree on the processing performed so > far. > > Yours sincerely, > Camelia > > -------------------------------------------- > On Wed, 7/3/13, Hyunsik Choi <[email protected]> wrote: > > Subject: Re: [GSoc2013] - Outer Join > To: "tajo-dev" <[email protected]> > Date: Wednesday, July 3, 2013, 10:04 PM > > Camellia, > > Since you submitted your proposal, I've been amazed at > your work. > > Your progress looks great. > https://sites.google.com/site/gsoc2013tajo34/home > > Especially, I would like to share this figure created by > camellia with > community. It looks very helpful for all of us. > http://goo.gl/LuwqH (The Life of A Query in Tajo) > > If you want more material about Tajo internal or need > out-of-scope issues > to be solved, please feel feel to ask me. > > Best regards, > Hyunsik > > > > > > > On Mon, Jun 17, 2013 at 7:34 AM, camelia c <[email protected]> > wrote: > > > Thank You very much for Your feedback and for the > materials You added this > > week on the Wiki. > > > > Yours sincerely, > > Camelia > > > > > > > > --- On Sun, 6/16/13, Hyunsik Choi wrote: > > > > > From: Hyunsik Choi > > > Subject: Re: [GSoc2013] - Outer Join > > > To: "tajo-dev" > > > Date: Sunday, June 16, 2013, 11:21 AM > > > Camellia, > > > > > > Your design document is really well surveyed. That > includes > > > very helpful > > > literature. If there are issues which are out of > scope of > > > your project > > > (TAJO-34) and should be done before your work, > please feel > > > free to ask me > > > or create additional Jira issues. > > > > > > Thanks, > > > Hyunsik > > > > > > > > > On Sat, Jun 8, 2013 at 11:12 PM, camelia c > > > wrote: > > > > > > > Hello, > > > > > > > > I uploaded version 1 of the SDD and here are > some items > > > to discuss & > > > > questions: > > > > > > > > 1) I assumed that the join condition is > specified in > > > the FROM clause, not > > > > in the WHERE clause. Is this assumption > fine? > > > > > > > > 2) Are there any PK and UNIQUE constraints in > TAJO? > > > > --> this > is > > > related to EXT 3.2 in the SDD, which otherwise is > not > > > > possible > > > > > > > > 3) At stage 5, DEC5.1. not sure if needed. > > > > > > > > 4) I need to understand better the link > between > > > TaskRunnerLaunchImpl, > > > > TaskRunnerListenerImpl, Task and > TaskRunner. Is > > > any documentation > > > > available, please? > > > > > > > > Next week, I plan to make a diagram as well > and to take > > > some example > > > > queries and analyze the output of each stage > of > > > processing for them. > > > > > > > > I look forward to receiving Your feedback! > > > > > > > > Thank You! > > > > Camelia > > > > > > > > > > > > > > > > --- On Sun, 6/2/13, Hyunsik Choi > > > wrote: > > > > > > > > From: Hyunsik Choi > > > > Subject: Re: [GSoc2013] - Outer Join > > > > To: "tajo-dev" > > > > Date: Sunday, June 2, 2013, 9:59 PM > > > > > > > > Camelia, > > > > > > > > Wow! That site really looks great and very > informative > > > to us. > > > > > > > > - hyunsik > > > > > > > > > > > > On Sat, Jun 1, 2013 at 5:12 AM, camelia c > > > wrote: > > > > > > > > > > > > > > Hello, > > > > > > > > > > This is the website I've created: > > > > > > > > > > https://sites.google.com/site/gsoc2013tajo34/home > > > > > > > > > > Thank You, > > > > > Camelia > > > > > > > > > > > > > > > --- On Thu, 5/30/13, Henry Saputra > > > wrote: > > > > > > > > > > From: Henry Saputra > > > > > Subject: Re: [GSoc2013] - Outer Join > > > > > To: "[email protected]" > > > > > > > > Date: Thursday, May 30, 2013, 3:00 PM > > > > > > > > > > You can link it to the Tajo wiki to > help > > > centralize the info about GSOC > > > > for > > > > > Tajo: http://wiki.apache.org/tajo/GSoC2013 > > > > > > > > > > Or you can create a page in the wiki for > the > > > design too. > > > > > > > > > > > > > > > - Henry > > > > > > > > > > > > > > > On Wed, May 29, 2013 at 7:41 PM, Hyunsik > Choi > > > > > > > wrote: > > > > > > > > > > > Hi camelia, > > > > > > > > > > > > That's good start. We could find > the right > > > way from your design > > > > document > > > > > > for this project. > > > > > > > > > > > > If your work is available online, I > don't > > > care. You can use Google > > > > site, > > > > > a > > > > > > blog, or github. You also can share > your work > > > on your blog and some > > > > code > > > > > > repository like github. > > > > > > > > > > > > Best regards, > > > > > > Hyunsik > > > > > > > > > > > > > > > > > > On Thu, May 30, 2013 at 5:31 AM, > camelia c > > > > > > > > wrote: > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > I started working at the > Software Design > > > Document for this project, > > > > as > > > > > > > planned in the schedule for > this period, > > > and I hope that by the start > > > > > of > > > > > > > next week( Monday, June 3rd) > to have the > > > version 1 of it to discuss > > > > it > > > > > > with > > > > > > > You. > > > > > > > > > > > > > > Also, I was wondering how do > You prefer > > > that I keep track online of > > > > the > > > > > > > work at the project: a Google > site or a > > > blog or what else do You > > > > > suggest? > > > > > > > Something like a weekly diary > of the > > > progress at this project. > > > > > > > > > > > > > > Thank You very much, > > > > > > > Camelia > > > > > > > > > > > > > > > > > > > > > --- On Tue, 5/28/13, Henry > Saputra > > > > > > wrote: > > > > > > > > > > > > > > From: Henry Saputra > > > > > > > Subject: Re: [GSoc2013] - > Outer Join > > > > > > > To: "[email protected]" > > > > > > > > > > Date: Tuesday, May 28, 2013, > 1:14 AM > > > > > > > > > > > > > > Woot! > > > > > > > > > > > > > > On Monday, May 27, 2013, > camelia c > > > wrote: > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > > > > > Thank You very much > for > > > having accepted my proposal for the TAJO > > > > > > > Project! > > > > > > > > > > > > > > > > Looking forward to plenty > of good > > > results working at TAJO, > > > > > > > > Camelia > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
