Hi Camelia,

PhysicalPlanner.createPlan is called in each worker. If you watch the
master log, you cannot see the log message. I would like to recommend you
to start this work from TestPhysicalPlanner, TestMergeJoinExec, or
TestHashJoinExec. With these unit tests, you can easily start your work.

Besides, if you finished the logical plan part and the part can be
separated from the remain work, you need to create a subtask of TAJO-34 and
commit the part to Tajo master branch. If not, you would handle the
conflict of your large work against the recent revision continuously. As
you can see, TAJO-121 was committed to the master branch. So, you could
easily add your outer join rewrite rules to Tajo query optimizer system. If
you need any help, please feel free to ask us.

Best regards,
Hyunsik Choi


On Mon, Aug 12, 2013 at 2:17 AM, camelia c <[email protected]> wrote:

> Hello,
>
> First of all, Thank You very much for the result of the midterm evaluation!
>
> I've started working on the physical operators' implementation for outer
> join and one issue is that I don't understand why the method createPlan in
> /incubator-tajo/tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalPlannerImpl
> is never called... or at least it seems so.
> I inserted a LOG.info command in this method and it doesn't appear in the
> output log.
>
> E.g.
>
> public PhysicalExec createPlan(final TaskAttemptContext context,
>       final LogicalNode logicalPlan) throws InternalException {
>
>     PhysicalExec plan;
>
>     try {
>       //camelia ---(
>       LOG.info("############# PhysicalExec: will call recursive create
> plan");
>       //camelia )---
>       plan = createPlanRecursive(context, logicalPlan);
>
>     } catch (IOException ioe) {
>       throw new InternalException(ioe);
>     }
>
>     return plan;
>   }
>
>
>
> Thank You in advance for Your reply!
>
> Yours sincerely,
> Camelia
>

Reply via email to