No worries, similar things that had to be added or rephrased also occurred during the .NET release of DeviceMap client, too;-)
Werner On Tue, Mar 29, 2016 at 1:14 PM, Anatole Tresch <[email protected]> wrote: > Ok. Seems that much more has been changed since last release. I am actually > glad someone else did have a deeper look at it, so we are back at square 1 > plus (we have input on things that are not correct anymore)... > Am 29.03.2016 13:08 schrieb "John D. Ament" <[email protected]>: > > > Hey guys, > > > > I asked Justin to take a look at the release since I'm the only active > > mentor. > > > > Based on his input and things I missed, I'm changing my vote to -1. > > > > You can find the JAR files here: > > > > Johns-MBP-2:apache-tamaya-0.2-incubating johnament$ find . -name "*.jar" > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.bundlerepository-2.0.6.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.configadmin-1.8.8.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.fileinstall-3.5.0.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.command-0.16.0.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.runtime-0.16.2.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.shell-0.10.0.jar > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.main-5.4.0.jar > > > > > > John > > > > ---------- Forwarded message --------- > > From: Justin Mclean <[email protected]> > > Date: Tue, Mar 29, 2016 at 7:04 AM > > Subject: Re: Need another hand > > To: John D. Ament <[email protected]> > > > > > > Hi, > > > > Sorry it taken a while, feel free to pass on to the dev list. > > > > And sorry to be the bearer of bad news but I’d vote -1 if I was a PPMC > > member or if it come up to vote on the IPMC as there are jars in the > source > > release. > > > > I checked: > > - artefacts contain incubating > > - signatures good > > - LICENSE ok but may be missing a few things (see below) > > - NOTICE doesn’t need to mention snake yaml as it’s apache licensed but > > could be fixed next release > > - unexpected jar files in source release (see below), but no other > > unexpected jars > > - all source files have Apache headers > > - can compile from source > > > > The binary LICENCE and NOTCE are not not correct given the bundled jars > > there need to be a lot more things mentioned in LICENSE and possibly > > NOTICE. I can help here but I’ve not looked into detail what would be > > required. > > > > Jar files (some which contain compiled code I did’t look at them all) > > include: > > org.apache.felix.bundlerepository-2.0.6.jar > > org.apache.felix.configadmin-1.8.8.jar > > org.apache.felix.fileinstall-3.5.0.jar > > org.apache.felix.gogo.command-0.16.0.jar > > org.apache.felix.gogo.runtime-0.16.2.jar > > org.apache.felix.gogo.shell-0.10.0.jar > > org.apache.felix.main-5.4.0.jar > > > > Source LICENSE is probably missing: > > - Asciidoctor (MIT) [1] > > - CodeRay? (MIT) [1] > > > > Thanks, > > Justin > > > > 1. ./distribution/src/main/assembly/index.html > > >
