yep, Felix may be used to build "Bundle-enabled" Tamaya modules, but I don't see where they would be needed by the library or framework.
Werner On Wed, Mar 30, 2016 at 10:10 PM, Anatole Tresch <[email protected]> wrote: > Hi Justin > > thank you very much helping us out here. I fixed a few things (not yet > committed): > > - The Apache felix jars are definitively not to be added. I even removed > them on the repo, since they are not needed anymore. *So there will not by > any unexpected jar files in source release anymore.* > - NOTICE: I removed the snakeyaml entry > > > > > > *Source LICENSE is probably missing:- Asciidoctor (MIT) [1]- CodeRay? (MIT) > [1]* > > *-> They are both used built time only, similar to RAT, FindBugs et al. as > maven extensions. Do they need to be added? If so, do you have an example?* > > > Additionally we have integration modules, that depend on others, which may > be to be mentioned: > *consul.io <http://consul.io>:* > Mozilla Public License, version 2.0 > > *-> if someone has a good example of how to add this correctly it would > awesome ;)* > > *All other deps are Apache projects (ALv2-licenced).* > > *Is there anything more we must do?* > > *Thanks, Anatole* > > > > 2016-03-29 13:07 GMT+02:00 John D. Ament <[email protected]>: > > > Hey guys, > > > > I asked Justin to take a look at the release since I'm the only active > > mentor. > > > > Based on his input and things I missed, I'm changing my vote to -1. > > > > You can find the JAR files here: > > > > Johns-MBP-2:apache-tamaya-0.2-incubating johnament$ find . -name "*.jar" > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.bundlerepository-2.0.6.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.configadmin-1.8.8.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.fileinstall-3.5.0.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.command-0.16.0.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.runtime-0.16.2.jar > > > > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.gogo.shell-0.10.0.jar > > > > ./modules/integration/osgi/test-bundles/org.apache.felix.main-5.4.0.jar > > > > > > John > > > > ---------- Forwarded message --------- > > From: Justin Mclean <[email protected]> > > Date: Tue, Mar 29, 2016 at 7:04 AM > > Subject: Re: Need another hand > > To: John D. Ament <[email protected]> > > > > > > Hi, > > > > Sorry it taken a while, feel free to pass on to the dev list. > > > > And sorry to be the bearer of bad news but I’d vote -1 if I was a PPMC > > member or if it come up to vote on the IPMC as there are jars in the > source > > release. > > > > I checked: > > - artefacts contain incubating > > - signatures good > > - LICENSE ok but may be missing a few things (see below) > > - NOTICE doesn’t need to mention snake yaml as it’s apache licensed but > > could be fixed next release > > - unexpected jar files in source release (see below), but no other > > unexpected jars > > - all source files have Apache headers > > - can compile from source > > > > The binary LICENCE and NOTCE are not not correct given the bundled jars > > there need to be a lot more things mentioned in LICENSE and possibly > > NOTICE. I can help here but I’ve not looked into detail what would be > > required. > > > > Jar files (some which contain compiled code I did’t look at them all) > > include: > > org.apache.felix.bundlerepository-2.0.6.jar > > org.apache.felix.configadmin-1.8.8.jar > > org.apache.felix.fileinstall-3.5.0.jar > > org.apache.felix.gogo.command-0.16.0.jar > > org.apache.felix.gogo.runtime-0.16.2.jar > > org.apache.felix.gogo.shell-0.10.0.jar > > org.apache.felix.main-5.4.0.jar > > > > Source LICENSE is probably missing: > > - Asciidoctor (MIT) [1] > > - CodeRay? (MIT) [1] > > > > Thanks, > > Justin > > > > 1. ./distribution/src/main/assembly/index.html > > > > > > -- > *Anatole Tresch* > Java Engineer & Architect, JSR Spec Lead > Glärnischweg 10 > CH - 8620 Wetzikon > > *Switzerland, Europe Zurich, GMT+1* > *Twitter: @atsticks* > *Blogs: **http://javaremarkables.blogspot.ch/ > <http://javaremarkables.blogspot.ch/>* > > *Google: atsticksMobile +41-76 344 62 79* >
