It looks like some tests that were passing are now failing in the branch. Empty values are suddenly failing (they were passing last time). Also looks like major API changes in Tamaya, Builder no longer supports setting type, configuration no longer has getFromValue.
On Tue, Oct 3, 2017 at 1:52 PM John D. Ament <[email protected]> wrote: > At this point the PR doesn't compile. So not sure what to do. It seems > like Anatole's moved forward on it anyways..... > > > On Sun, Oct 1, 2017 at 5:02 PM P. Ottlinger <[email protected]> wrote: > >> Am 30.09.2017 um 23:13 schrieb Anatole Tresch: >> > I shortly looked at it. It makes sense, so +1 to merge from my side... >> >> I'm unable to accept the PR .... not sure if it's a bug with the >> Github-integration, but +1 from me. >> >> Phil >> >
