[
https://issues.apache.org/jira/browse/TAMAYA-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349201#comment-16349201
]
ASF GitHub Bot commented on TAMAYA-327:
---------------------------------------
GitHub user peculater opened a pull request:
https://github.com/apache/incubator-tamaya/pull/11
TAMAYA-327: Consistent signature creating ConversionContexts
Comments in ConversionContext lead me to believe that supportedFormats
should have their order maintained after import. The HashSet that the
Builder object uses as a backer will not accomplish that goal. This
change converts the Builder to use ArrayLists for supportedFormats, like
the object proper.
Some additional tests have been added here in pursuit of TAMAYA-288's
additional code coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/peculater/incubator-tamaya TAMAYA-327
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tamaya/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit f63ba99ffaf4050827fc0ad88cd5df91f506956d
Author: William Lieurance <william.lieurance@...>
Date: 2018-02-01T20:16:27Z
TAMAYA-327: Consistent signature creating ConversionContexts
Comments in ConversionContext lead me to believe that supportedFormats
should have their order maintained after import. The HashSet that the
Builder object uses as a backer will not accomplish that goal. This
change converts the Builder to use ArrayLists for supportedFormats, like
the object proper.
Some additional tests have been added here in pursuit of TAMAYA-288's
additional code coverage.
----
> Inconsistent signature for creating ConversionContext
> -----------------------------------------------------
>
> Key: TAMAYA-327
> URL: https://issues.apache.org/jira/browse/TAMAYA-327
> Project: Tamaya
> Issue Type: Bug
> Reporter: William Lieurance
> Priority: Major
>
> During some additional testing in the API added as part of TAMAYA-288, I came
> across an inconsistency between the ConversionContext and the
> ConversionContext.Builder. Namely, the comments say that supportedFormats
> have their order maintained, which is consistent with the use of an ArrayList
> here
> [https://github.com/apache/incubator-tamaya/blob/master/code/api/src/main/java/org/apache/tamaya/spi/ConversionContext.java#L42]
> . The builder, however implements the same supportedFormats with a HashSet,
> which does not ensure order. See
> [https://github.com/apache/incubator-tamaya/blob/master/code/api/src/main/java/org/apache/tamaya/spi/ConversionContext.java#L148]
> .
> I'm planning on creating a pull request with the additional tests for that
> object as well as a patch to more consistently maintain order (all
> ArrayLists). Please let me know if the better answer is to more consistently
> leave order unspecified (all HashSets).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
