Hi All, There is a quartet of Jira issues related to consolidating the test assertion code so that AssertJ is used (TAMAYA-216, TAMAYA-217, TAMAYA-218 and TAMAYA-219). At present, there is a combination of AssertJ, JUnit and Hamcrest in use throughout the tests. I have three open pull requests that make these changes:
https://github.com/apache/incubator-tamaya/pull/32 https://github.com/apache/incubator-tamaya-extensions/pull/25 https://github.com/apache/incubator-tamaya-sandbox/pull/17 The commits involve a lot of line changes, though there are no changes to any of the testing logic (or any of the main codebase). If there is interest in moving the test code in this direction, it would be nice to get these changes merged sooner rather than later, since any other changes to the test code easily leads to merge conflicts. Also, once these three PRs are merged, we could add a checkstyle rule to prohibit the use of JUnit/Hamcrest assertions in the future, which would make it easier to keep the test code more consistent. And in terms of process, should I be waiting for someone to merge these PRs? Or should I push these commits directly to master? Thanks, Aaron
