Thanks for the review. With these changes now in place, I started looking at adjusting the checkstyle rules to enforce (or at least prevent the use of JUnit assertions), but it seems that the checkstyle configuration isn't run on a typical `mvn clean verify` or `mvn clean install`. As it is, there are a few checkstyle violations in the code, and it may be worthwhile revisiting some of the rules.
What would you all think about adjusting the maven configuration to have checkstyle run on each build? Initially, it might make sense to just report the errors rather than failing an entire build because of them. I can supply a PR for this. Best, Aaron > On Jan 16, 2019, at 2:57 PM, P. Ottlinger <pottlin...@apache.org> wrote: > > Dear Aaron, > > Am 16.01.19 um 15:40 schrieb Aaron Coburn: >> https://github.com/apache/incubator-tamaya/pull/32 >> https://github.com/apache/incubator-tamaya-extensions/pull/25 >> https://github.com/apache/incubator-tamaya-sandbox/pull/17 > > Thanks for all your work - I remember (because I started to do some > replacements in the code ;) ) that the test code has a lot of ordering > problems within assertions. > > Sorry for my many review comments - maybe it's easier to do a search and > replace for some of the more simpler assertions with Optionals/Collections. > > Thanks, > Phil
