Start page redirect requests can return an empty response.
----------------------------------------------------------

                 Key: TAPESTRY-1627
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1627
             Project: Tapestry
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.0.5
            Reporter: Nick Westgate


A Start page redirect request will produce an empty response if the request URL 
was root, e.g: http://localhost:8080/myapp/
It will succeed only if the URL maps to the Start page, eg: 
http://localhost:8080/myapp/start

It looks like just a couple of lines need to be (changed/added) in 
org.apache.tapestry.internal.services.RootPathDispatcher.dispatch()
[Marked by -/+ below.]

    public boolean dispatch(Request request, final Response response) throws 
IOException
    {
        // Only match the root path

        if (!request.getPath().equals("/")) return false;

        if (_componentClassResolver.isPageName(_startPageName))
        {
-            _handler.handle(_startPageName, _emptyContext);
+            ActionResponseGenerator responseGenerator = 
_handler.handle(pageName, context);

+            if (responseGenerator != null) 
responseGenerator.sendClientResponse(response);

            return true;
        }

        return false;
    }

Cheers,
Nick.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to