Built-in ValidationMessages cannot be overriden with contribution
-----------------------------------------------------------------
Key: TAPESTRY-2605
URL: https://issues.apache.org/jira/browse/TAPESTRY-2605
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.14, 5.0.13
Reporter: Christian Köberl
Attachments: ValidationMessagesSourceImplTest.patch
If you contribute validation messages with "contributeValidationMessagesSource"
for a language without built-in texts provided the texts are overriden by the
English built-in versions.
The reason for this seems to be in MessagesSourceImpl#findBundleProperties.
Here, the bundle values are cached in a simple Map. The code calls
MessagesSourceImpl#extend which overrides all contributed messages with the
default ones (even in another language).
There is no really simple way to fix this - that's why I did not provide a
patch. One solution could be to use an OrderedConfiguration for MessageSources
or to have something like factory-defaults vs. application-defaults.
I provided a patch for the ValidationMessagesSourceImplTest - this makes the
test fail because of this issue (just to make it more understandable).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
