[ 
https://issues.apache.org/jira/browse/TAP5-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard M. Lewis Ship closed TAP5-14.
------------------------------------

    Resolution: Duplicate

TAP5-253 looks to fix this issue as well.

> Built-in ValidationMessages cannot be overridden with contribution
> ------------------------------------------------------------------
>
>                 Key: TAP5-14
>                 URL: https://issues.apache.org/jira/browse/TAP5-14
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.0.15
>            Reporter: Christian Köberl
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>         Attachments: ValidationMessagesSourceImplTest.patch
>
>
> If you contribute validation messages with 
> "contributeValidationMessagesSource" for a language without built-in texts 
> provided the texts are overridden by the English built-in versions.
> The reason for this seems to be in MessagesSourceImpl#findBundleProperties. 
> Here, the bundle values are cached in a simple Map. The code calls 
> MessagesSourceImpl#extend which overrides all contributed messages with the 
> default ones (even in another language).
> There is no really simple way to fix this - that's why I did not provide a 
> patch. One solution could be to use an OrderedConfiguration for 
> MessageSources or to have something like factory-defaults vs. 
> application-defaults.
> I provided a patch for the ValidationMessagesSourceImplTest - this makes the 
> test fail because of this issue (just to make it more understandable).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to