I just reread the e-mail and realized you were saying the exact opposite...
that the contributions methods should be the superset of the services...
whereas I was thinking it made sense for the service's markers to be a superset
of the contribution's markers. But if you just changed the equals to contains
all in the code, that would make the code look for the service's markers to be
a superset of the contribution's markers. Doesn't that make more sense?
@Color @Blue
contributeSomething(...)
@Color
SomeService()
We probably wouldn't want contributeSomething to contribute into SomeService,
because the additional marker suggests that we are trying to contribute more
specifically than just @Color.
But if we had:
@Color @Blue
SomeService
@Color
contributeSomething()
Then /probably/ contributeSomething should contribute to SomeService. That
makes the Service's markers a superset of the contribution's markers.
Cheers,
Robert
PS: Yes, I realize my syntax for marking a service is wrong. Consider the
above pseudocode. :)
On Jul 6, 2010, at 7/65:20 PM , Howard Lewis Ship wrote:
> I'm looking over this code right now, from ModuleImpl:
>
> public Set<ContributionDef2>
> getContributorDefsForService(ServiceDef serviceDef)
> {
> Set<ContributionDef2> result = CollectionFactory.newSet();
>
> for (ContributionDef next : moduleDef.getContributionDefs())
> {
> ContributionDef2 def = InternalUtils.toContributionDef2(next);
>
> if (serviceDef.getServiceId().equals(def.getServiceId()))
> {
> result.add(def);
> }
> else
> {
> Set<Class> markers =
> CollectionFactory.newSet(def.getMarkers());
>
> if (markers.contains(Local.class))
> {
> if
> (moduleDef.getServiceDef(serviceDef.getServiceId()) == null)
> continue;
>
> markers.remove(Local.class);
> }
>
> if (serviceDef.getMarkers().equals(markers) // Why equals()
> ?
> && serviceDef.getServiceInterface() ==
> def.getServiceInterface())
> {
> result.add(def);
> }
> }
> }
>
> return result;
> }
>
>
> I think that's an error, comparing the services markers to the
> contribution methods markers using equals(). I believe that should be
> containsAll(). As in, the contribution method's annotations are a
> super-set of the service's marker annotations.
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
