... and many thanks to Igor for fixing those two checklist label issues!

Bob Harner
On Nov 8, 2011 1:47 AM, "Josh Canfield" <[email protected]> wrote:

> > That would be really cool, but is it possible to do?
> It's harder than making Loop generic because you actually need the
> type information within the class.
>
> Looking at it, it might be better to grab the generic info from the
> parameter binding itself. That is available at runtime, but not
> currently maintained by the property conduit.
>
> I spent a little time playing with it tonight but it looks like it
> might take a more concerted effort. I'll try to spend some time on it
> for 5.4 if someone doesn't beat me to it.
>
> Josh
> On Mon, Nov 7, 2011 at 4:24 PM, Bob Harner <[email protected]> wrote:
> > That would be really cool, but is it possible to do?
> >
> > On Mon, Nov 7, 2011 at 12:36 PM, Josh Canfield <[email protected]>
> wrote:
> >>>> 3) This component takes an "encoder" parameter but does not support
> a>> ValueEncoder configured to be provided automatically by Tapestry.
> >> It would be nice to migrate all of the collection based components to
> >> a generic form.
> >>
> >> With the generic information you could also pick the right value
> encoder.
> >>
> >> private Checklist<Fruit> userChecklist;
> >>
> >> would use the configured ValueEncoder<Fruit>.
> >>
> >> Josh
> >>
> >> On Mon, Nov 7, 2011 at 1:12 AM, Igor Drobiazko <
> [email protected]> wrote:
> >>> hi,
> >>>
> >>> On Sun, Nov 6, 2011 at 5:24 PM, Bob Harner <[email protected]>
> wrote:
> >>>
> >>>> Hi everybody,
> >>>>
> >>>> I've been meaning to bring this up for a while now. The new-for-5.3
> >>>> Checklist component has -- for me -- a couple of minor annoyances:
> >>>>
> >>>> 1) The label for each checkbox is positioned *before* (that is, to the
> >>>> left of) the checkbox. I think it is much more common to want the
> >>>> label *after* (to the right of) the checkbox.
> >>>>
> >>>
> >>> Can't it be done by overriding the CSS?
> >>>
> >>>>
> >>>> 2) The <label> for each checkbox is not connected to the checkbox with
> >>>> a "for" attribute, so you can't click on the label to check or uncheck
> >>>> the box.
> >>>>
> >>>
> >>> Fixed. https://issues.apache.org/jira/browse/TAP5-1747
> >>>
> >>>>
> >>>> 3) This component takes an "encoder" parameter but does not support a
> >>>> ValueEncoder configured to be provided automatically by Tapestry.
> >>>>
> >>>>
> >>> This is done for the same reason Palette component doesn't provide a
> >>> default encoder. We discussed that issue some time ago in the
> developers
> >>> list.
> >>>
> >>>
> >>>
> >>> --
> >>> Best regards,
> >>>
> >>> Igor Drobiazko
> >>> http://tapestry5.de
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [email protected]
> >> For additional commands, e-mail: [email protected]
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to