Jochen, You're right of course. Removing that <t:label> from Book.tml fixed the issue. So Hotel Booking is now running 5.4-rc-1 at http://tapestry-vm.apache.org:8080/hotels seemingly without problems.
I also found the same issue with another app of mine, and Chris P. and Kalle K. also reported the same problem in TAP5-2509. So I think it's apparently pretty common for people to have this construct in their TML files. It wouldn't be too bad if the error message weren't misleading (implying that it's the <t:form> that lacks the client side id) . I don't know if that means generating another RC, though. Maybe we need some more opinions on that. On Thu, Nov 12, 2015 at 2:26 PM, Jochen Kemnade <kemn...@gmail.com> wrote: > Hi, > > Jochen Kemnade <kemn...@gmail.com> schrieb am Do., 12. Nov. 2015 um > 20:08 Uhr: > > > I was unable to use RC1 for my recent Hotel Booking app changes due to a > >> bug that I believe you fixed just after the RC1 release (maybe > >> TAP5-2500?). > >> I think it was something about the <t:form> element failing if it didn't > >> have a client-side ID, but I can't provide details at the moment. I need > >> to > >> try the latest nightly build. > >> > > > > I'll try to run the app with RC-1 tomorrow, maybe we can find a > > workaround. I'd like to avoid the hassle of creating and voting on > another > > RC if possible. > > > > I had a quick look at he repository. I guess the problem is in > > https://github.com/bobharner/tapestry5-hotel-booking/blob/master/src/main/resources/com/tap5/hotelbooking/pages/Book.tml#L51 > where a > t:label is linked to a t:radiogroup. The radiogroup does not render > anything, so there is no clientId to put into the Label's for attribute. > You could change that to a regular HTML label. See also TAP5-2509 and > > https://github.com/apache/tapestry-5/commit/18ea654718212d4f65d98fb7a106bfbbecc34d47 > . > Maybe we should add a special case for RadioGroup inside Label as that > seems to be a common use case. > > Jochen >
