Hi, ----- On Mar 24, 2017, at 1:25 PM, Thiago H. de Paula Figueiredo thiag...@gmail.com wrote: >> Shouldn't dom.getEventUrl throw or at least warn if it cannot determine >> the url for the event, e.g. if you forget to add the @PublishEvent >> annotation? >> > > Right now it returns null. Well, another good idea. :) Or maybe we could > leave the say it is and let the caller handle null values and properly > document this
I think it is an error case and it should throw or warn. I usually try to adhere to the convention that if methods are named get*, it is an error if there is nothing to get, as opposed to find*. > The code I've wrote so far doesn't have automated tests, but the demo page > is actually a test: notice the Expected and the Value columns. They should > match for each row. I'd appreciate if you added some tests. > Did you create 5.4.2 with or without this feature? 5.4.2 includes the feature in its current state. Cheers, Jochen --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
