On Sun, Sep 22, 2019 at 5:54 AM Andrus Adamchik <aadamc...@gmail.com> wrote:
> I am +1 (non-binding) > Thank you very much! > Here is my evaluation checklist: > > * MD5 matches... Since MD5 is easily reversible these day, I guess it > would make sense to provide SHA512 signature in the future. > We already provide SHA512 signatures in Maven artifacts. Indeed, the non-Maven ones only have MD5 signatures. We shall improve this in future releases, even though I seriously doubt anyone uses Tapestry without Maven. Thanks for the warning! > > * Signature checks pass > > * NOTICE and LICENSE files are present > > * Apache-rat checks pass... With my particular set of rat excludes, I got > 1439 "unlicensed" files (i.e. those without Apache headers). Those are > either tests, test resources, build-related files, or third-party > (build-related or otherwise) files. So while Apache license headers can > probably be added to some of them, hopefully that's not a big deal. What we > did in the past with 3rd-party files in Cayenne, is moving their original > license headers to NOTICE.txt, and adding Apache headers instead. > > * Builds from source > > Finally I am also planning to try it with "bootique-tapestry" module of > Bootique framework and upgrade a number of other projects, but this will > require much more time. So to cast my vote, I just focused on license > checking and formal correctness of the release. > > Andrus > > > > > On Sep 21, 2019, at 3:51 PM, Thiago H. de Paula Figueiredo < > thiag...@gmail.com> wrote: > > > > Hello, Andrus and Dmitry! > > > > Indeed, while trying to remove a set of 5.5.0 artifacts that shouldn't be > > there, I ended up removing all the 5.5.0-beta-* files by mistake. Thanks > > for noticing this! > > > > This is fixed now. I was going to post the voting results now, but I'll > > wait for Andrus' vote Monday. > > > > On Wed, Sep 18, 2019 at 10:30 AM Andrus Adamchik <aadamc...@gmail.com> > > wrote: > > > >>> 2. > >> > https://repository.apache.org/content/repositories/staging/org/apache/tapestry/ > >> (the latest release is 5.3.0 here) > >> > >> Never mind this one. Found 5.5.0 under individual modules (initially was > >> looking at the wrong module folder). > >> > >> Still don't see anything under > >> https://dist.apache.org/repos/dist/dev/tapestry > >> > >> Andrus > >> > >> > >>> On Sep 18, 2019, at 4:22 PM, Andrus Adamchik <aadamc...@gmail.com> > >> wrote: > >>> > >>> Hi Thiago, > >>> > >>> I may be missing something, but I don't see "5.5.0-beta-3" artifacts > >> under either of the links: > >>> > >>> 1. https://dist.apache.org/repos/dist/dev/tapestry (the latest release > >> is 5.4.5 here) > >>> 2. > >> > https://repository.apache.org/content/repositories/staging/org/apache/tapestry/ > >> (the latest release is 5.3.0 here) > >>> > >>> Andrus > >>> > >>> > >>>> On Sep 17, 2019, at 1:21 AM, Thiago H. de Paula Figueiredo < > >> thiag...@gmail.com> wrote: > >>>> > >>>> I've created and uploaded a release of Tapestry 5.5.0, ready to be > voted > >>>> upon. It's meant to be a preview of the next major Tapestry release, > >> 5.5.0. > >>>> The main new feature in 5.5.0-beta-3 is the ability of running > Tapestry > >>>> without Bootstrap CSS (a minimal set of JavaScript Bootstrap modules > is > >>>> included so alerts and validation message works), with Bootstrap 3 > (the > >>>> default) or Bootstrap 4. More details in > >>>> https://issues.apache.org/jira/browse/TAP5-2612. > >>>> > >>>> The source, binary, and documentation archives have been uploaded to: > >>>> > >>>> https://dist.apache.org/repos/dist/dev/tapestry > >>>> > >>>> and the Maven artifacts staged to: > >>>> > >>>> > >>>> > >> > https://repository.apache.org/content/repositories/staging/org/apache/tapestry/ > >>>> > >>>> Please examine these files to determine if the new release, > >> 5.5.0-beta-3, > >>>> is ready. > >>>> > >>>> I've also created a v5.5.0-beta-3 tag in Git: > >>>> > >>>> > >>>> > >> > https://gitbox.apache.org/repos/asf?p=tapestry-5.git;a=commit;h=cbedad6f1d457c883faaeaf3f9fcbbec3de99816 > >>>> > >>>> It includes the following tickets: > >>>> > >>>> > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20TAP5%20AND%20fixVersion%20%3D%205.0.0 > >>>> > >>>> Vote will run for at least three days and requires majority approval > >> from > >>>> the PMC: At least 3 binding +1 votes and more positive than > >>>> negative binding votes. > >>>> > >>>> On a successful vote, I'll release the Maven artifacts, the archives, > >>>> and make the necessary updates to JIRA and the Tapestry site. > >>>> > >>>> Only votes cast by Tapestry PMC members are binding, but input > >>>> from the community is highly valued. Please indicate whether your > >>>> vote is binding or not after your full name (as it will appear in > >>>> the end-of-vote summary). > >>>> > >>>> -- > >>>> Thiago > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > >> For additional commands, e-mail: dev-h...@tapestry.apache.org > >> > >> > > > > -- > > Thiago > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > For additional commands, e-mail: dev-h...@tapestry.apache.org > > -- Thiago
