On Fri, May 13, 2022 at 12:45 PM Volker Lamp <vl...@apache.org> wrote:
> Hello, Tapestry developers, Hello, everyone! > The @DisableStrictChecks annotation > (https://issues.apache.org/jira/browse/TAP5-2655) causes a split package > (in terms of Java 9 modules) with tapestry-core. Oh, argh, I should have thought of that while creating that annotation, specially because I had already done the work of avoiding the way too many split packages Tapestry had before 5.7.0. Thanks so much for spotting this! > In my opinion, the best fix is to move it into tapestry-core. While the > jar would change, the package would stay the same, causing fewer to no > migration issues - hopefully. Hmm, I think the best option is to move it to keep it in tapestry5-annotations and move it to org.apache.tapestry5.core.annotations. It won't be backward compatible, but on the other hand it's just one annotation, it's very new and I suppose there aren't many people using it, if any (except my day job, which uses it in a handful of places). Also, we do have a migration tool introduced with 5.7.0 for this kind of stuff, even if I don't think it's necessary in this case. I do agree with Ben that keeping annotations in the annotations JAR is the best way to go for consistency. -- Thiago --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
