I tried moving the annotations from tapestry-core to tapestry5-annotations and got a number of compilation errors due to the annotations using tapestry-core classes, so I reached the conclusion that it's not really feasible to do it for all annotations. I moved @DisableStrictChecks to tapestry-core.
Volker, have you been using Tapestry in a fully modular webapp? I'm curious to know how you noticed the unintended split package. What about a release next week? I've just committed CORS support and I'm looking forward to get it released. :) In addition, we already have 10 tickets in 5.8.2: https://issues.apache.org/jira/issues/?jql=project%20%3D%20TAP5%20AND%20fixVersion%20%3D%205.8.2. Cheers! On Tue, May 24, 2022 at 2:38 PM Thiago H. de Paula Figueiredo <thiag...@gmail.com> wrote: > > On Sat, May 21, 2022 at 9:12 AM Volker Lamp <vl...@apache.org> wrote: > > Hello Thiago and Ben, > > Hello! > > > I think you got that confused, Thiago. At this time, @DisableStrictChecks > > is in org.apache.tapestry5.annotations within tapestry5-annotations (not > > tapestry-core). All other annotation of package > > org.apache.tapestry5.annotations are in tapestry-core. > > Oh, sorry, I definitely got it the wrong way around. > > > From the discussion so far I understand the consensus is to have all > > annotations in tapestry5-annotations. That is, the 54 files (53 annotations > > + package-info.java) currently living in tapestry-core would stay in the > > org.apache.tapestry5.annotations package but would move to > > tapestry5-annotations. This should be smooth for users, as tapestry-core > > has a transitive dependency on tapestry5-annotations (through tapestry-ioc) > > already. For clarity, a direct dependency to tapestry5-annotations should > > be added to tapestry-core. > > > > I created https://issues.apache.org/jira/browse/TAP5-2724 to take care of > > this. > > Agreed and thanks for creating the ticket and raising this issue in first > place. > > > > > Thanks, > > > > Volker > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org > > For additional commands, e-mail: dev-h...@tapestry.apache.org > > > > > -- > Thiago -- Thiago --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
