Seems there are still some issues with the CssCompressor, as I ran my tests with Java 17 by accident...
On Sat, Jun 17, 2023 at 11:36 AM Ben Weidig <b...@netzgut.net> wrote: > Hello! > > > I would like to see the CssCompressor stuff getting merged if someone > could take a quick look at it. > > > https://github.com/apache/tapestry-5/pull/40/ > > > That's what I did: > > - Take the latest code from YUICompressor > - Fix the Java compile errors (seriously?) > - Move all the existing unit tests over to Tapestry, added > bootstrap.css minification test so it behaves like before > - Fix TAP5-2753 so CSS variables work again in calc > - Optimize the YUI code for our use case: less "InputStream -> Writer > -> String and back" stuff, use StringBuilder instead of StringBuffer, > refactor all Regexes to precompiled Pattern constants > > As the YUICompressor project is dead anyway, my reasoning was to create a > more maintainable variant, as CSS still evolves, and we might need to fix > it again in the future. > > > Everything else I've done directly on master: > > - TAP5-2735: LocalizationSetter setNonPersistentLocaleFromRequest added > - TAP5-2736: CookieBuilder maxAge fix parameter name / improve > Duration support > - TAP5-2743: PerThreadValue<T> convenience methods > > > Cheers! > > Ben > > On Fri, Jun 16, 2023 at 8:05 PM Thiago H. de Paula Figueiredo < > thiag...@gmail.com> wrote: > >> Hi! >> >> Tonight I'm going to merge a new opt-in feature into master, the >> option of having multiple classloaders for smarter live class >> reloading. I'm also seriously thinking of adding another little >> feature to allow non-soft references to cached page instances. >> >> I'm wondering whether you guys have been thinking about including >> other stuff in this release. If not, I'd like to cut it and start the >> voting thread in 1 week or 2. >> >> Thoughts? >> >> Cheers! >> >> -- >> Thiago >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org >> For additional commands, e-mail: dev-h...@tapestry.apache.org >> >> > >
