Hi Thiago > I was looking at TAP5-2749 and I saw you mentioned that Spock tests > weren't run. I vaguely recall disabling them around Tapestry 5.7.0 due > to the package changes. Are the Spock tests being run now? If not, > please let me know and I'll take a look at it.
Spock tests are currently *not* being run. They require useJUnitPlatform() in the Gradle build script but useTestNG() is configured. I started working on this in the context of TAP5-2741 (see https://github.com/apache/tapestry-5/pull/38), re-arranging the build logic to use Convention Plugins in order to avoid the legacy allprojects/subprojects style. I intend to leverage the Gradle 'jvm-test-suite' plugin which adds a convenient way of defining different test suits each with different test framework dependencies. So our existing TestNG and Spock would continue to co-exist. However, I'm currently stuck with a circular dependency on tapestry-javadoc. Hopefully I'll find a way out once I understand Gradle dependency configurations a little bit better. As I'm not sure when I'll find the time to do that, and with regard to the 5.8.3 release, I'd just leave the Spock tests disabled on the build server. One can run them locally by replacing useTestNG() with useJunitPlatform() in build.gradle:202 (at the cost of disabling the TestNG tests, obviously. Thanks, Volker --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org For additional commands, e-mail: dev-h...@tapestry.apache.org
