On 21-Jun-16 08:21, Nadeesh Dilanga wrote:
Hi Stain, Hi Alan, Can you please review the code with my latest commit @ https://github.com/NadeeshDilanga/incubator-taverna-common-activities/commits/docker where I came up with a Configuration Manager and also implemented "Configurable".
I think you need a separate interface called DockerContainerConfiguration as well as the class DockerContainerConfigurationImpl. DockerActivity should then take a DockerContainerConfiguration not a DockerContainerConfigurationImpl.
I would like to add a unit test case for this by creating a DockerContainerConfigurationImpl and inject a ConfigurationManager. Can you please point me to such example. I tried, but could not find anything yet. i.e I was not able to find a usage of "DatabaseConfigurationImpl" in taverna-engine/taverna-osgi/taverna-common-activities repos.
DatabaseConfiguration and DatabaseConfigurationImpl are in the Taverna engine not in the common activities. For the unit test, I think it is OK to create an explicit DockerContainerConfigurationImpl and insert that into the DockerActivity.
Because I am planning to have a proper test case before the mid term evaluation deadline. Also appreciate if you can provide your feedback/expectations on this project's mid point
I will be satisfied if you can retrieve the metadata about an image and, if possible, talk to a container.
and if it has any required TODOs I can complete them ASAP before the mid term evaluation deadline.
Rather than implement your own REST calls to talk to a container, have you looked at https://github.com/docker-java/docker-java ? If it is too difficult to switch, then I think your REST utils are OK for the moment,
Alan
