On 18-Jun-16 08:12, Nadeesh Dilanga wrote:
Hi Alan, Hi Stian,
Please refer my latest commit @
https://github.com/NadeeshDilanga/incubator-taverna-common-activities/commits/docker/taverna-docker-activity
where I have implemented reading a injected configuration. Can you please
review this and let me know what I am missing here. But one thing I would
like to know is, who is responsible of creating(populating) the
DockerContainerConfiguration ?
In the workbench, users are able to change such configurations. That is
normally done under the File -> Preferences. I think for GSOC it is
enough to specify what needs to be in the configuration.
We have to allow user to give a docker.conf
and from which some one construct the DockerContainerConfiguration and
inject it to the activity plugin.
Yes, long term we do. However, for GSOC it is enough to take a
hand-written docker.conf
Your DockerContainerConfigurationImpl certainly looks to have the
correct type of information.
Then I went through the taverna-engine repo code base looking for the clue
Stian gave, where I have to implement Configurable interface, and use
ConfigurationManager. And Configuration manager interface had
store/populate methods to override, but I found it bit unclear to figure
out how exactly I can use that to my use case/how it works/relation ship
between Configurable interface and ConfigurationManager. Do we have any
documentation on that ?
I am not sure. Stian and Gale may know.
For SSL issue, I am calling the container as
https://192.168.99.100:2376/containers/create where 192.168.99.100 is my
container host. I assume that is the target you meant ?
Yes.
Alan
