This went a bit tricky in the end.. so are we back to square 0 or can we try again for another RC2? It's not a blocker really if it says RC2 inside the folder name.. just misleading. (if the vote passes then 1.0.0-RC2 == 1.0.0)
On Thu, 4 Apr 2019 14:01:58 +0100, Ian Dunlop <ianwdun...@gmail.com> wrote: > Hello, > > I think I know what you mean now. It’s the folder name inside the .tar.gz > when you explode it. Hmm. That seems to be be automatically put together by > GitHub based on the repo name and the tag name. Ie incubator-taverna-mobile & > 1.0-incubating-RC2. That’s slightly annoying. > So it looks like this GitHub release mechanism isn’t so great after all. Or > at least I’ll have to open the file and change the name then gzip it back up. > Oh well. > > Cheers, > > Ian > > Sent from Mail for Windows 10 > > From: Ian Dunlop > Sent: 04 April 2019 13:40 > To: dev@taverna.incubator.apache.org > Subject: RE: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > Hello, > > @Stian I need a bit of clarification. Why did you say > -1 "-RC1" in folder name inside (not ideal) > > Having RC1 in the folder name seems to agree with the instructions I follow > at > https://taverna.incubator.apache.org/community/releasing#uploading-to-distapacheorg > “Under source/, make a corresponding versioned folder for each product, and > include the RC number, avoiding confusion in case you need to make a second > release candidate:” > > Cheers, > > Ian > > > Sent from Mail for Windows 10 > > From: Ian Dunlop > Sent: 04 April 2019 13:19 > To: Sagar > Cc: dev@taverna.incubator.apache.org; Stian Soiland-Reyes > Subject: RE: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > Hello, > > Ok so I’m cancelling the current RC1 vote, merging the changes into master > and starting a vote on RC2. > > Cheers, > > Ian > > Sent from Mail for Windows 10 > > From: Sagar > Sent: 03 April 2019 16:19 > To: Ian Dunlop > Cc: dev@taverna.incubator.apache.org; Stian Soiland-Reyes > Subject: Re: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > This looks good to me. > > On Wed, Apr 3, 2019 at 4:00 PM Ian Dunlop <ianwdun...@gmail.com> wrote: > Hello, > > Adding the gradle download into the travis file appears to work. See > https://travis-ci.org/apache/incubator-taverna-mobile/builds/515120359. I > rolled the gradle changes back out of master and put them in branch > ian_travis_gradle. If everyone thinks this is an ok direction then we can > merge back into master and go for RC2 without the binary. > > Cheers, > > Ian > > Sent from Mail for Windows 10 > > From: Ian Dunlop > Sent: 02 April 2019 18:10 > To: Sagar > Cc: dev@taverna.incubator.apache.org; Stian Soiland-Reyes > Subject: Re: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > Hello > > The first answer on > https://stackoverflow.com/questions/42818269/is-gradlew-mandatory-for-travis-ci-to-work/43493907 > suggests that you can get travis to create a gradle wrapper for you. We > could try that and see if it works. I'm just trying to make the process > simple. For Devs you only need to install gradle and run the gradle wrapper > command once and then you are all setup. I guess we could also write a shell > script to create the bundle for us. Open to all suggestions. > Feel free to back out any of my changes if they are causing you problems but > we need to think of a solution. > > Cheers > > Ian > > On Tue, 2 Apr 2019, 18:00 Ian Dunlop, <ianwdun...@gmail.com> wrote: > Hello > > That makes it a tricky problem to solve. If we can't rely on the GitHub tag > for the bundle then we will need to create our own after cloning and removing > the gradle folder. Can Travis create a gradle wrapper before building? I'm > happy to go with creating our own bundle but it is more work. Remove git > folder, remove gradle etc. > > Cheers > > Ian > > On Tue, 2 Apr 2019, 17:15 Sagar, <kumarsagar15...@gmail.com> wrote: > Due to removing the wrapper. We will not able to build the project. It is > required to build the android code. Travis is also failing because of this. > > On Tue, Apr 2, 2019 at 8:53 PM Ian Dunlop <ianwdun...@gmail.com> wrote: > Hello > > I just commited some fixes. Hopefully all the files have the correct headers > now. I also removed the gradle wrapper. Now you have to create the wrapper > yourself when you first clone the project. Seems like the easiest way to > avoid the binary issue. I think I've got the issues fixed so I can try and > put RC2 together soon. Hopefully my key issue is fixed as well. Maybe someone > could check for me. > > Cheers, > > Ian > > On Tue, 2 Apr 2019, 15:10 Sagar, <kumarsagar15...@gmail.com> wrote: > @Ian Dunlop Are you working on the issues or do I make the change? > > > > On Mon, Apr 1, 2019 at 9:41 PM Ian Dunlop <ianwdun...@gmail.com> wrote: > Hello, > > The key fingerprint is the same as listed in the KEYS file. Does that mean > the key is the same? > > Cheers, > > Ian > > Sent from Mail for Windows 10 > > From: Stian Soiland-Reyes > Sent: 01 April 2019 16:43 > To: Ian Dunlop > Cc: dev@taverna.incubator.apache.org > Subject: RE: [DISCUSS] Release Apache Taverna Mobile 1.0-incubating-RC1 > > You'll also need to update the KEYS file in dist. > > On Mon, 1 Apr 2019 13:39:40 +0100, Ian Dunlop <ianwdun...@gmail.com> wrote: > > Hello, > > > > @Sagar don’t forget to give it a +1 on the [VOTE] thread if you think it > > passes all the Apache release criteria. I think I just posted my VOTE to > > the DISCUSS thread – not sure message threading is working correctly in my > > email client. Apologies for any confusion. > > > > I’ve updated my key on the keyservers (gpg & ubuntu though they should both > > sync anyway). Let’s see if that fixes things because I’m sure I’ve updated > > them before. > > I guess we should give them 24 hours to sort themselves out and then gpg > > --refresh-keys to update your local keys. > > > > -- > > Warmest regards > Sagar > Software Developer > Lattice Innovations Pvt. Ltd. > > > > -- > > Warmest regards > Sagar > Software Developer > Lattice Innovations Pvt. Ltd. > > > > > -- > > Warmest regards > Sagar > Software Developer > Lattice Innovations Pvt. Ltd. > > >
