TheButlah commented on code in PR #268:
URL:
https://github.com/apache/teaclave-trustzone-sdk/pull/268#discussion_r2707234338
##########
optee-teec/optee-teec-sys/build.rs:
##########
@@ -19,25 +19,29 @@ use std::env::{self, VarError};
use std::path::PathBuf;
fn main() -> Result<(), VarError> {
- if !is_feature_enable("no_link")? {
- link();
+ if !is_feature_enabled("no_link")? {
+ link(is_env_present("TEEC_STATIC")?);
Review Comment:
I think it might be unintuitive to diverge at all from pkg-config's
semantics. They only check for env var presence, not the 1 vs 0 value. See
[here](https://docs.rs/pkg-config/0.3.32/src/pkg_config/lib.rs.html#759)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
