Github user gokulavasan commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/28#discussion_r97421547
--- Diff:
tephra-hbase-compat-1.1-base/src/main/java/org/apache/tephra/hbase/coprocessor/TransactionProcessor.java
---
@@ -140,29 +141,25 @@ public void start(CoprocessorEnvironment e) throws
IOException {
ttlByFamily.put(columnDesc.getName(), ttl);
}
- this.allowEmptyValues =
env.getConfiguration().getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY,
-
TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
+ String allowEmptyValuesFromTableDesc =
tableDesc.getValue(TxConstants.ALLOW_EMPTY_VALUES_KEY);
+ this.allowEmptyValues = (allowEmptyValuesFromTableDesc != null) ?
Boolean.valueOf(allowEmptyValuesFromTableDesc) :
+
getConfiguration(env).getBoolean(TxConstants.ALLOW_EMPTY_VALUES_KEY,
TxConstants.ALLOW_EMPTY_VALUES_DEFAULT);
--- End diff --
I think this property is used in preGetOp. Ideally, this should be read
only from the tableDesc and set. If we do it lazily, then we might get
different results for a Get operation based on whether we were able to read the
Configuration successfully or not. I can modify this to read it only from
tableDesc similar to the other property (READ_NON_TX_DATA)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
